Is singing baby to sleep a bad habit?

She’s 9 months old and she likes to fall asleep with me singing to her and holding my finger. I don’t mind it, but should I be teaching her to fall asleep on her own? I’m a first time mom and just want to make sure I’m doing okay 😬