New to this does this look about right as still working it all out