Cup in the middle of the night

CR

My son is almost 18 months old and he still wakes up in the middle of the night. We give him a cup milk and hold him for a little bit... What am I doing wrong here? I would love full nights rest, I work 12 hour shifts 5a to 5p