To end this marriage or not

I am tired. I've been with this man child for 11 years and we have 2 kids together. I still love him but I often feel miserable. First of all, let me start by saying that he has ADHD and he often uses this as an excuse. He's been in school on and off for over a decade trying to get his bachelor's degree. He hasn't finished due to repeating classes, and can't manage money so he isn't able to save enough for the next semester. He isn't stupid, his priorities are just jacked up. For example, he'll play video games instead of studying for an exam. Or as soon as he gets paid from work, he wants to blow his money on food. Plus repeating classes has been so expensive, basically throwing throwing thousand of dollars down the drain. We have other problems like getting things done at home (our apartment). I have to nag him to get things done around here or I often end up doing it myself. On both of my pregnancies I asked him to take walks with me, we did a few with my first and ONCE in my second. We don't live in the best neighborhood which is why I would often ask him.

A few good things about him. He can be really sweet sometimes. He was my best friend prior to our love relationship. He's a great listener, he's funny, loyal. During my pregnancies he'd go beyond and get me my cravings. He still does sometimes if I'm having a bad day. He'll sacrifice his sleep and take care of the kids so I can nap.

I supported him through all his mistakes, like I paid most of his courses. But it put us in debt. This year we finally got our taxes that can put us out of debt and have an opportunity to buy a house together. But I'm scared. We've had the same fights over and over again about how irresponsible he can be. After these fights he would improve and do things around our home without me asking. But this usually lasts for about a week. I feel like his parent more than a partner sometimes, which also affects our sex lives. I no longer feel the desire to feel pleased by him. He knows how I feel because we had these talks. He often apologizes for the way he is, but my patience is running out. I am basically the reason why we have a roof over our heads.

He is my first love. My best friend. I can't imagine being with someone else. But how much longer should I hold on??