When should be the time to be engaged?

I’ve been dating this guy for 4 years, since high school. He always tells me he’s broke and he sees a future with me but I’m kinda getting the hint that he’s just trying to keep me from seeing other people. What time did you guys get engaged? How much longer should I give him?